Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users of FDM can update to FiniteDifferences #37

Closed
nickrobinson251 opened this issue Aug 7, 2019 · 3 comments
Closed

Users of FDM can update to FiniteDifferences #37

nickrobinson251 opened this issue Aug 7, 2019 · 3 comments

Comments

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Aug 7, 2019

We should add the following advice to the README?

  • We renamed the package for discoverability
  • Turns out to rename it we had to actually register it as a new package (with a new UUID)...
  • This means the old FDM URL redirects here. Packages dependening of FDM will not be affected. But all future updates will be to FiniteDifferences (not FDM).
  • As far as i can tell, functionally this new package has no breaking changes from the last FDM release (counting Check that the derivative is nonnegative, and handle the case q == 0 #34 as a bug-fix)
  • User can safely update their Project.toml files from
[deps]
FDM = "e25cca7e-83ef-51fa-be6c-dfe2a3123128"
...

[compat]
FDM = "0.6"

to

[deps]
FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000"
...

[compat]
FiniteDifferences = "0.7"
@nickrobinson251 nickrobinson251 added the good first issue Good for newcomers label Aug 7, 2019
@nickrobinson251 nickrobinson251 changed the title Adivise users of FDM can/should update to FiniteDifferences Advise users of FDM update to FiniteDifferences Aug 7, 2019
@nickrobinson251
Copy link
Contributor Author

need the package to be registered first JuliaRegistries/General#2535

@nickrobinson251 nickrobinson251 removed the good first issue Good for newcomers label Aug 11, 2019
@nickrobinson251 nickrobinson251 changed the title Advise users of FDM update to FiniteDifferences Users of FDM can update to FiniteDifferences Aug 11, 2019
@nickrobinson251
Copy link
Contributor Author

Added a note to the README (#38). It just links to this issue which has all the info at the top ^^^

Let's leave the issue open for now - so people can find it and in case people have questions on updating - but I don't think anything else needs doing here :)

@oxinabox
Copy link
Member

I think we can now close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@oxinabox @nickrobinson251 and others