Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check addresspace before doing a bitcast for small tags #51517

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Check addresspace before doing a bitcast for small tags #51517

merged 1 commit into from
Sep 30, 2023

Conversation

gbaraldi
Copy link
Member

Found and should fix JuliaGPU/GPUCompiler.jl#504. Similar to #38424

@gbaraldi gbaraldi requested review from vtjnash and maleadt September 29, 2023 18:55
@maleadt maleadt added compiler:codegen Generation of LLVM IR and native code gpu Affects running Julia on a GPU labels Sep 29, 2023
maleadt
maleadt approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vtjnash vtjnash merged commit f27619c into master Sep 30, 2023
@vtjnash vtjnash deleted the gb/fix-addrspace branch September 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code gpu Affects running Julia on a GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCN: Assertion failure due to stack address space
3 participants
@gbaraldi @maleadt @vtjnash