Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #34
My pull request to VoronoiDelauny was merged. My PR allows us to seed the call to
random!
that was causing the non-deterministic behavior, as the different orders of operations were leading to differences in the floating point answer.Here I have made an optional RNG argument to the call to
voronoicells
. My tests show that if you provide RNGs with different seeds,voronoicells
gives two different answers, and that if we provide the same seed we get the same answer.This requirers VoronoiDelauny v0.4.4, which I changed in the
Project.toml
.