Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaGizmos/Blink.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 303fb3e005c81b9d535f63ed6f9b4c1b62f6838b
Choose a base ref
..
head repository: JuliaGizmos/Blink.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c8abde2aa80ac6fe08196eb3dadfc7cf768d89f6
Choose a head ref
Showing with 1 addition and 2 deletions.
  1. +1 −2 src/AtomShell/window.jl
3 changes: 1 addition & 2 deletions src/AtomShell/window.jl
Original file line number Diff line number Diff line change
@@ -32,11 +32,10 @@ end

function Window(a::Shell, content::Page, opts::AbstractDict = Dict())
url = Blink.localurl(content)
is_async(opts) = get(opts, :async, false)
is_async(opts) = get(opts, :async, true) # Async default: true
callback = !is_async(opts)
if callback
# Send the callback id as a query param in the url.
# TODO: Is there a better way to communicate params to the web server?
id, cond = Blink.callback!()
url *= "?callback=$id"
end