Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do about quit(::ElectronShell)? #142

Closed
tkoolen opened this issue Aug 15, 2018 · 2 comments · Fixed by #190
Closed

What to do about quit(::ElectronShell)? #142

tkoolen opened this issue Aug 15, 2018 · 2 comments · Fixed by #190

Comments

@tkoolen
Copy link
Contributor

tkoolen commented Aug 15, 2018

Blink has:

https://github.com/JunoLab/Blink.jl/blob/3eff4999627968c979a7526de7cc218aa39e6755/src/AtomShell/process.jl#L107

where quit is imported from Base. quit is deprecated in 0.7 (now exit). Arguably, Base.quit shouldn't have been extended in the first place, so I don't think it should be replaced with an overload of Base.exit now. Should AtomShell.quit just not be exported?
@pfitzseb
Copy link
Member

That seems sensible to me, yes.

@NHDaly
Copy link
Collaborator

NHDaly commented Aug 18, 2018

To me too, fwiw

@rdeits rdeits mentioned this issue Sep 15, 2018
Closed
This was referenced Mar 7, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop extending nonexistent Base.quit JuliaGizmos/Blink.jl
3 participants
@NHDaly @tkoolen @pfitzseb