We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window
!
We should rename the Window API functions to be more julian. Either adding a ! at the end of setters, or more explicitly set__ and get__ or is__?
set__
get__
is__
That is, for these ones: https://github.com/JunoLab/Blink.jl/blob/d984c4d99586c451395cba55eadf8b47d9cac091/src/AtomShell/window.jl#L87-L136
There's a setter and a getter for a bunch of them (position, size, etc).
position
size
Can I rename those to position!(w, x, y) and position(w)?
position!(w, x, y)
position(w)
(I came across this as part of #160 😄)
The text was updated successfully, but these errors were encountered:
Cross Referencing related discussion here: #212 (comment)
Sorry, something went wrong.
active(::Window)
Another API renaming x-ref: #122 (comment)
load! should be renamed import!.
load!
import!
Successfully merging a pull request may close this issue.
We should rename the
Window
API functions to be more julian. Either adding a!
at the end of setters, or more explicitlyset__
andget__
oris__
?That is, for these ones:
https://github.com/JunoLab/Blink.jl/blob/d984c4d99586c451395cba55eadf8b47d9cac091/src/AtomShell/window.jl#L87-L136
There's a setter and a getter for a bunch of them (
position
,size
, etc).Can I rename those to
position!(w, x, y)
andposition(w)
?(I came across this as part of #160 😄)
The text was updated successfully, but these errors were encountered: