Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the setters in the Window API functions with a ! #161

Open
NHDaly opened this issue Oct 6, 2018 · 2 comments
Open

Rename the setters in the Window API functions with a ! #161

NHDaly opened this issue Oct 6, 2018 · 2 comments

Comments

@NHDaly
Copy link
Collaborator

NHDaly commented Oct 6, 2018

We should rename the Window API functions to be more julian. Either adding a ! at the end of setters, or more explicitly set__ and get__ or is__?

That is, for these ones:
https://github.com/JunoLab/Blink.jl/blob/d984c4d99586c451395cba55eadf8b47d9cac091/src/AtomShell/window.jl#L87-L136

There's a setter and a getter for a bunch of them (position, size, etc).

Can I rename those to position!(w, x, y) and position(w)?

(I came across this as part of #160 😄)

@NHDaly NHDaly added the question label Oct 6, 2018
@NHDaly
Copy link
Collaborator Author

NHDaly commented Aug 22, 2019

Cross Referencing related discussion here: #212 (comment)

@NHDaly NHDaly changed the title Rename the setters in the Window API functions with a !? Rename the setters in the Window API functions with a ! Aug 22, 2019
@NHDaly
Copy link
Collaborator Author

NHDaly commented Aug 22, 2019

Another API renaming x-ref: #122 (comment)

load! should be renamed import!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant