Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blink looking for 7z.exe in wrong place (Julia 1.3.0) #224

Closed
pgunnink opened this issue Dec 17, 2019 · 2 comments
Closed

Blink looking for 7z.exe in wrong place (Julia 1.3.0) #224

pgunnink opened this issue Dec 17, 2019 · 2 comments
Labels
windows

Comments

@pgunnink
Copy link
Contributor

Blink currently looks for 7z.exe on Windows in the location joinpath(ENV["LOCALAPPDATA"], juliafolders[i], "bin", "7z.exe"), (see install.jl here) which is no longer supported in Julia 1.3.0. 7z.exe now lives in joinpath(Sys.BINDIR, "..", "libexec"), as indicated in this Julia PR and also verified on a new install of Julia 1.3.0 on my Windows machine.

This should be relatively trivial to fix by checking for the version number and selecting the right folder, or simply by trying both folders. I would be willing to make a PR for this, but I don't know which approach would be preferable.
@pgunnink pgunnink mentioned this issue Dec 17, 2019
Closed
@pgunnink
Copy link
Contributor Author

I created a PR here.

@tkoolen tkoolen mentioned this issue Dec 28, 2019
Closed
@twavv
Copy link
Member

twavv commented Jan 1, 2020

Closed by #229.

@twavv twavv closed this as completed Jan 1, 2020
@twavv twavv added the windows label Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed new location of 7z.exe in Julia 1.3.0 pgunnink/Blink.jl
2 participants
@twavv @pgunnink