webio_serve and @app doesn't work

[leo60228]

Any request made using webio_serve and @app times out. The same code with Mux.stack works.

[stefan911]

I can't get any routing other than to "/" to work:

app = Mux.stack(page("/failhttp", req -> respond("fail")),
page("/", req -> itworks()),
page("/failws", req -> nope()))
WebIO.webio_serve(app, 8088)

appending /webio-socket to routes vs not appending seems to be the issue:
/webio-socket vs /failws/webio-socketin my case

[stefan911]

Digging deeper :src/providers/mux.jl is appending the "webio-socket" string removing this from the websocket routing allows routing to work.

websock = Mux.App(Mux.mux(
Mux.wdefaults,
Mux.route("/", create_socket), #"/webio-socket" only seems to work at root
Mux.wclose,
Mux.notfound(),
))

This leads to a socket left open when leaving the page, forcing a close in the exception covers up the error rather than fixing it:

Mux/src/websockets_integration.jl
function wcatch(app, req)
try
app(req)
catch e
println(stderr, "Error handling websocket connection:")
showerror(stderr, e, catch_backtrace())
close(req[:socket]) #236 added to "recover" from exception.
end
end

[cstjean]

@stefan911 Make a PR! It would be great to have a fix for this issue.

[shashi]

Thanks @cstjean for #379