setexcludinghandlers! was removed in Observables 0.5

[rasmushenningsson]

With the compat update to support Observables 0.5, we get problems here

WebIO.jl/src/scope.jl

Line 352 in c818b1f

Observables.setexcludinghandlers!(ob, val)

since setexcludinghandlers! no longer exists.
I'm not sure what a proper fix is.

The easiest fix would probably be to just access the field directly, since the function was implemented like this in Observables.jl:
setexcludinghandlers!(obs::AbstractObservable, val) = observe(obs).val = val

[PetrKryslUCSD]

Is there some fix? PlotlyJS is practically unusable because of this error.

[mzaffalon]

@PetrKryslUCSD I pin WebIO to v0.8.17 as a temporarily workaround:
using Pkg; Pkg.add("WebIO"); Pkg.pin(name="WebIO", version="0.8.17").

[PetrKryslUCSD]

Excellent, that worked! Thanks!

[rasmushenningsson]

bump 🙂

[twavv]

Open to PRs here. Looks like this was a breaking change introduced to Observables.jl in https://github.com/JuliaGizmos/Observables.jl/pull/84/files#diff-717dd66a485f4523942145feb17dfcebc7bf9e137ee03fa29c1ef8c8c3b1cad6L272 (cc @SimonDanisch)

[rasmushenningsson]

I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead.
If they don't want to reintroduce it, I'll open a PR with a local fix here.

[rcqls]

I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead. If they don't want to reintroduce it, I'll open a PR with a local fix here.

@rasmushenningsson Why you don't do that. If you have a fix it could be a good point. I can't understand why PlotlyJS event handling is stuck because of this issue. That"s weird in the excellent Julia ecosystem.

[rasmushenningsson]

The PR in Observables was just merged, so no need for any action here.