Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Core.include #370

Closed
musm opened this issue Jun 21, 2017 · 3 comments
Closed

Add support for Core.include #370

musm opened this issue Jun 21, 2017 · 3 comments

Comments

@musm
Copy link
Contributor

musm commented Jun 21, 2017

Would it be possible to also add support for Base.include https://github.com/JuliaLang/julia/blob/3c3ced4153cdc2c75319b41155c38ad1f2545fc2/base/boot.jl#L233
i.e. include accepting a module in the first argument

@stevengj
Copy link
Member

We normally don't add Compat support for undocumented Julia internals...

@stevengj stevengj changed the title Add support for Base.include Add support for Core.include Jun 21, 2017
@stevengj
Copy link
Member

Changing the title as I think you mean Core.include, not Base.include.

The second argument was added in JuliaLang/julia#22064. Before that PR, the internal jl_load functions themselves did not take a module argument, so it would be hard to implement this in Compat … I guess we could parse the file one expression at a time and call eval with the desired module argument.

@martinholters
Copy link
Member

Closing as outdated since we've dropped support for Julia prior to 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants