-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping download of lazy artifacts #464
Comments
CC: @staticfloat - i think we talked with you and @KristofferC about this on slack. Do you think something like an Thanks! |
It makes sense to me to have that option, at least. |
This is quite painful for CUDA.jl given all of the many large artifacts are lazy https://github.com/JuliaGPU/CUDA.jl/blob/master/Artifacts.toml And a |
Bumping as this issue bit us again just now. Given
I'll roll Rob's branch into a pull request so that we can begin iterating something. Thanks folks! :) |
This is now merged into PackageCompiler |
When using PackageCompiler.jl, we ran into an issue with TimeZone.jl [0] where it downloaded all timezone data (200+ files). These files are listed as
lazy
. We would like to avoid downloading them, and in the issue linked, it was mentioned we should probably add aninclude_lazy_artifacts
option.I tried to add an
include_lazy_artifacts
option [1], however, it is probably not a correct solution, as it ignores the situation where there is aDict
in the Artifact section. See first part of the if at https://github.com/RelationalAI-oss/PackageCompiler.jl/blob/rv-include-lazy/src/PackageCompiler.jl#L722 .This patch, although probably incorrect, solved our immediate issue (we ger blocked by the server when downloading too many files).
I think this probably only can be fixed in Pkg.jl, but not sure how. Any idea how to get this fixed properly?
[0] JuliaTime/TimeZones.jl#300
[1] master...RelationalAI-oss:rv-include-lazy
The text was updated successfully, but these errors were encountered: