-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building fresh (non-incremental) sysimages on Julia nightly (Julia 1.12) #1002
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
- Coverage 84.56% 84.07% -0.50%
==========================================
Files 3 3
Lines 823 829 +6
==========================================
+ Hits 696 697 +1
- Misses 127 132 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Closes #996, I'm guessing? |
Looks like we are now hitting:
|
09ee30b
to
59a8c00
Compare
Requires JuliaLang/julia#56601 |
It looks like nightly CI might timeout here, in which case we will need to increase the timeouts along the lines of #1003. |
Indeed, nightly CI timed out at the old timeout (90 minutes) on this PR. Let's see if increasing the timeouts (#1003) fixes things. |
CI is all green. Codecov is unhappy, but that's just because we don't run code coverage on every job in our matrix (to try to save some CI time). |
@KristofferC Is this good to merge? |
Fixes #989.
Replaces #996 (closes #996).