Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building fresh (non-incremental) sysimages on Julia nightly (Julia 1.12) #1002

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Nov 15, 2024

Fixes #989.

Replaces #996 (closes #996).

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (38629b0) to head (b719aaf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/PackageCompiler.jl 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   84.56%   84.07%   -0.50%     
==========================================
  Files           3        3              
  Lines         823      829       +6     
==========================================
+ Hits          696      697       +1     
- Misses        127      132       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DilumAluthge
Copy link
Member

Closes #996, I'm guessing?

@DilumAluthge
Copy link
Member

Looks like we are now hitting:

error during bootstrap:

LoadError(at "/opt/hostedtoolcache/julia/nightly/x64/share/julia/base/Base_compiler.jl" line 291: ErrorException("File "./../usr/share/julia/Compiler/src/Compiler.jl" not found"))

@DilumAluthge DilumAluthge changed the title try fix building non-incremental sysimages on nightly try fix building non-incremental sysimages on Julia nightly Nov 18, 2024
@KristofferC
Copy link
Member Author

Requires JuliaLang/julia#56601

@DilumAluthge
Copy link
Member

It looks like nightly CI might timeout here, in which case we will need to increase the timeouts along the lines of #1003.

@DilumAluthge
Copy link
Member

Indeed, nightly CI timed out at the old timeout (90 minutes) on this PR. Let's see if increasing the timeouts (#1003) fixes things.

@DilumAluthge DilumAluthge changed the title try fix building non-incremental sysimages on Julia nightly Fix building fresh (non-incremental) sysimages on Julia nightly Nov 21, 2024
@DilumAluthge
Copy link
Member

CI is all green.

Codecov is unhappy, but that's just because we don't run code coverage on every job in our matrix (to try to save some CI time).

@DilumAluthge
Copy link
Member

@KristofferC Is this good to merge?

@DilumAluthge DilumAluthge changed the title Fix building fresh (non-incremental) sysimages on Julia nightly Fix building fresh (non-incremental) sysimages on Julia nightly (Julia 1.12) Nov 21, 2024
@KristofferC KristofferC merged commit 72387f9 into master Nov 21, 2024
43 of 45 checks passed
@KristofferC KristofferC deleted the kc/nightly branch November 21, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Julia 1.12: Creating fresh base sysimage (incremental=false) fails with error during bootstrap
2 participants