Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excluded_packages keyword argument for create_sysimage #791

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhubonan
Copy link
Contributor

Added a excluded_packages keyword to create_sysimage which allows certain packages to be unconditionally excluded in the sysimage.

Such option can be useful when one want to compile a sysimage for package development where the dependences contain heavy packages with long load times (e.g. found using @time_imports using MyDevPackage in Julia >= 1.8).

In this case, building a system image including the dependencies can significantly reduce the load times of the package in development.

For example, one may want to create a system image with MyDevPackage included in the packages keyword argument with include_transitive_dependencies=true to ensure its dependencies are included. Then put MyDevPackage inside excluded_packages so MyDevPackage itself is not included in the sysimage (otherwise one cannot develop MyDevPackage.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #791 (7ea9961) into master (df35434) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   83.08%   83.15%   +0.07%     
==========================================
  Files           3        3              
  Lines         668      671       +3     
==========================================
+ Hits          555      558       +3     
  Misses        113      113              
Impacted Files Coverage Δ
src/PackageCompiler.jl 93.19% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sloede
Copy link
Collaborator

sloede commented Mar 2, 2023

Are there any updates for this PR? To have an easy way for selecting all dependencies of a package without the package itself seems like a nice improvement for usability

@zhubonan
Copy link
Contributor Author

zhubonan commented Mar 2, 2023

Are there any updates for this PR? To have an easy way for selecting all dependencies of a package without the package itself seems like a nice improvement for usability

No update from my side - waiting for inputs from the maintainer I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants