Precompile/import into main flags & warnings for package name conflicts #794
+44
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 83.08% 82.23% -0.85%
==========================================
Files 3 3
Lines 668 670 +2
==========================================
- Hits 555 551 -4
- Misses 113 119 +6
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
FWIW, using |
krynju
added a commit
that referenced
this pull request
Oct 9, 2024
…lution (#807) This contains only the `import_to_main` part of #794 Fixes #768 Changelog: 1. added `import_into_main` flag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimage 2. added skip & warnings on the import to Main name conflict #768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
import_into_mainflag (default true), which allows you to control whether the top level packages will be imported into Main in the sysimagedisable_precompileflag (default false), which allows you to turn off the precompile part of the build completelyWhile this doesn't fix the #767 and #768 issues it makes them not error, which in most cases will be fine.
If not then the warning should point the user at some possible solution.
The current solutions to both of these problems are either using the flags added in this PR or modifying the precompile statements.