Make interrupting Pkg.test more graceful
#2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a definite UX improvement, but would appreciate a second opinion |
|
+1, the current behavior is annoying and feels buggy as a user |
vtjnash
reviewed
Apr 21, 2022
| printpkgstyle(ctx.io, :Testing, "Tests interrupted. Exiting the test process\n", color = Base.error_color()) | ||
| # Give some time for the child interrupt handler to print a stacktrace and exit, | ||
| # then kill the process if still running | ||
| if timedwait(() -> !process_running(p), 4) == :timed_out |
There was a problem hiding this comment.
Using timedwait is often a general design problem, where you can usually use a Timer(4) and wait(p) instead though
vtjnash
reviewed
Apr 21, 2022
| printpkgstyle(ctx.io, :Testing, "Tests interrupted. Exiting the test process\n", color = Base.error_color()) | ||
| # Give some time for the child interrupt handler to print a stacktrace and exit, | ||
| # then kill the process if still running | ||
| if timedwait(() -> !process_running(p), 4) == :timed_out |
There was a problem hiding this comment.
Using timedwait is often a general design problem, where you can usually use a Timer(4) and wait(p) instead though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
^C-ing aPkg.testcan result in a big mess of mixed-up InterruptException stack traces from the child and parent process, and it's common for the child process to not actually get interrupted given there's only one shot for the^Cto get through to the child before the parent is interrupted and closes the signal forwarding, making it orphaned by the parent and continue to run tests while the parent process tries to go back to the repl, no matter how many times the user^C's, requiring the user to find the orphaned process and kill it.This change tries to make the process more graceful:
pkg>prompt once the child process is stopped, to avoid the prompt being printed-overThis PR
Closes #2922