Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove graphics.jl and Graphics module from base #10150

Merged
merged 2 commits into from
Feb 20, 2015
Merged

Conversation

jakebolewski
Copy link
Member

As discussed in #9862.

@ViralBShah
Copy link
Member

Sweet!

@JeffBezanson
Copy link
Member

Yes this is fine, but if any packages are extending these methods we need to set up a Geometry.jl package replacement right away.

@garborg
Copy link
Contributor

garborg commented Feb 10, 2015

In #9862, @timholy mentioned Color.jl, Cairo.jl, Gtk.jl, Images.jl, ImageView.jl, ProfileView.jl, Tk.jl, and Winston.jl.

@jakebolewski
Copy link
Member Author

Could you create a JuliaLang/Graphics git repo for this?

@ViralBShah
Copy link
Member

https://github.com/JuliaLang/Graphics.jl

You should have commit access too.

@JeffBezanson
Copy link
Member

Ok, but there will still need to be some refactoring since not all graphics packages will use all of this.

@ViralBShah
Copy link
Member

Coming to think of it, Graphics.jl was not a good name. Perhaps GraphicsFoundation.jl or GraphicsAPI.jl would have been a better name. This might mislead some newcomers.

@sjkelly
Copy link
Contributor

sjkelly commented Feb 11, 2015

@JeffBezanson
Copy link
Member

Yes, the name is a problem, but the geometry and rendering API parts need to be separated as well.

jakebolewski added a commit that referenced this pull request Feb 20, 2015
remove graphics.jl and Graphics module from base
@jakebolewski jakebolewski merged commit 8c87a32 into master Feb 20, 2015
@jakebolewski jakebolewski deleted the jcb/rmgraphics branch February 20, 2015 05:10
@StefanKarpinski StefanKarpinski added the excision Removal of code from Base or the repository label Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excision Removal of code from Base or the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants