kill `isleaftype` #25496

vtjnash · 2018-01-10T19:38:39Z

As discussed in previous issues (listed below), this finishes the deprecation of isleaftype and adds/corrects a number of other type-property queries and their usages (esp. including isbits). This correction also includes a number of changes that makes inference more powerful (by leveraging the removal of isleaftype to return more correct answers, yay!).

Most of the new computations are cached inside a datatype upon construction:

// properties of `parameters`
     uint8_t hasfreetypevars; // majority part of isconcrete computation
+    uint8_t isconcretetype; // where this type can have instances
+    uint8_t isdispatchtuple; // aka isleaftupletype
// properties of `types`
+    uint8_t isbitstype; // relevant query for C-api and type-parameters
+    uint8_t zeroinit; // if one or more fields requires zero-initialization
+    uint8_t isinlinealloc; // if this is allocated inline
// removed attributes
-    int32_t depth; // not a well-defined concept
-    int8_t isleaftype; // already deprecated, now gone

fix #25044
fix #23567
fix #17086
fix #25310

~~This still needs docs from #17086 (comment), and I should go back through and add some tests. But wanted to start by publish the functional changes now.~~

JeffBezanson · 2018-01-10T19:53:59Z

src/intrinsics.cpp

    else if (ty != to) {
-        unboxed = ctx.builder.CreateBitCast(unboxed, to);
+            unboxed = ctx.builder.CreateBitCast(unboxed, to);


indentation

JeffBezanson · 2018-01-10T20:11:52Z

👍 Looks great!

timholy · 2018-01-10T21:05:30Z

base/reflection.jl


-_isleaftype(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && t.isleaftype)
+_isleaftype(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && (t.isdispatchtuple || t.isconcretetype)) # deprecated
+isdispatchtuple(@nospecialize(t)) = (@_pure_meta; isa(t, DataType) && t.isdispatchtuple)


Docs? It's exported.

nalimilan · 2018-01-12T09:57:25Z

base/reflection.jl

+end
+
+"""
+    Base.isstructype(T) -> Bool


isprimitivetype

nalimilan · 2018-01-12T09:57:33Z

base/reflection.jl

-isstructtype(t::DataType) = (@_pure_meta; length(t.types) != 0 || (t.size==0 && !t.abstract))
-isstructtype(x) = (@_pure_meta; false)
+"""
+    Base.isstructype(T) -> Bool


isstructtype

vtjnash · 2018-01-15T20:03:34Z

@nanosoldier runbenchmarks(ALL, vs = ":master")

nanosoldier · 2018-01-15T21:08:57Z

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @ararslan

ararslan · 2018-01-15T21:17:32Z

Random moving to the stdlib broke Nanosoldier. I have a fix up, I just need to retune the benchmarks then I'll run Nanosoldier here when that's done.

ararslan · 2018-01-16T04:18:09Z

@nanosoldier runbenchmarks(ALL, vs=":master")

nanosoldier · 2018-01-16T10:16:20Z

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

vtjnash · 2018-01-16T16:39:25Z

Seems mostly noise, but let me run that again to see if any are consistently changed: @nanosoldier runbenchmarks(ALL, vs=":master")

ararslan · 2018-01-16T20:05:02Z

@nanosoldier runbenchmarks(ALL, vs=":master")

nanosoldier · 2018-01-17T01:29:25Z

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

vtjnash · 2018-01-17T04:38:53Z

@nanosoldier runbenchmarks(ALL, vs=":master")

ararslan · 2018-01-17T06:11:38Z

@nanosoldier runbenchmarks(ALL, vs=":master")

nanosoldier · 2018-01-17T12:09:51Z

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

widen Tuple faster, to Any, if it's already nesting

…ned data

expand the set of them to be more "complete", and document them more fully

JeffBezanson · 2018-01-19T15:51:24Z

🎉

vtjnash added potential benchmark Could make a good benchmark in BaseBenchmarks needs tests Unit tests are required for this change needs docs Documentation for this change is required needs news A NEWS entry is required for this change labels Jan 10, 2018

ararslan requested review from JeffBezanson and Keno January 10, 2018 19:45

JeffBezanson reviewed Jan 10, 2018

View reviewed changes

timholy reviewed Jan 10, 2018

View reviewed changes

vtjnash force-pushed the jn/isleaftype-kill branch from bdaa13f to 786dafb Compare January 12, 2018 00:34

vtjnash removed the needs docs Documentation for this change is required label Jan 12, 2018

nalimilan reviewed Jan 12, 2018

View reviewed changes

vtjnash removed the needs news A NEWS entry is required for this change label Jan 13, 2018

vtjnash force-pushed the jn/isleaftype-kill branch from 786dafb to d33f30f Compare January 15, 2018 19:20

vtjnash removed the needs tests Unit tests are required for this change label Jan 15, 2018

vtjnash removed the potential benchmark Could make a good benchmark in BaseBenchmarks label Jan 15, 2018

KristofferC mentioned this pull request Jan 15, 2018

List of deprecations to implement JuliaComputing/Deprecations.jl#20

Open

32 tasks

vtjnash force-pushed the jn/isleaftype-kill branch from d33f30f to 90a5b22 Compare January 15, 2018 21:36

vtjnash force-pushed the jn/isleaftype-kill branch from 90a5b22 to c9d254d Compare January 16, 2018 16:37

vtjnash force-pushed the jn/isleaftype-kill branch from c9d254d to ff415e4 Compare January 16, 2018 19:36

vtjnash force-pushed the jn/isleaftype-kill branch from ff415e4 to 02baf98 Compare January 17, 2018 04:35

vtjnash force-pushed the jn/isleaftype-kill branch 4 times, most recently from b230e03 to 5cc69d1 Compare January 18, 2018 22:13

vtjnash added 5 commits January 19, 2018 00:44

fix unlimited_type_size growth of Tuple

ad703e8

widen Tuple faster, to Any, if it's already nesting

fix bugs in show_method_candidates

6147df6

codegen: tolerate type mismatches in dead code

32ce590

isbits-unions: is and object_id predicates were looking at undefi…

c39f18b

…ned data

fix type-predicate queries

88a4db2

expand the set of them to be more "complete", and document them more fully

vtjnash force-pushed the jn/isleaftype-kill branch from 5cc69d1 to 88a4db2 Compare January 19, 2018 05:45

vtjnash merged commit 4f0b09e into master Jan 19, 2018

vtjnash deleted the jn/isleaftype-kill branch January 19, 2018 15:50

cormullion mentioned this pull request Mar 18, 2018

NEWS.md is getting a bit untidy #26508

Closed

Seelengrab mentioned this pull request Jul 5, 2024

Docs talk about removed "Leaf types" #55044

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kill `isleaftype` #25496

kill `isleaftype` #25496

vtjnash commented Jan 10, 2018 •

edited

Loading

JeffBezanson Jan 10, 2018

JeffBezanson commented Jan 10, 2018

timholy Jan 10, 2018

nalimilan Jan 12, 2018

nalimilan Jan 12, 2018

vtjnash commented Jan 15, 2018

nanosoldier commented Jan 15, 2018

ararslan commented Jan 15, 2018

ararslan commented Jan 16, 2018

nanosoldier commented Jan 16, 2018

vtjnash commented Jan 16, 2018

ararslan commented Jan 16, 2018

nanosoldier commented Jan 17, 2018

vtjnash commented Jan 17, 2018

ararslan commented Jan 17, 2018

nanosoldier commented Jan 17, 2018

JeffBezanson commented Jan 19, 2018

kill isleaftype #25496

kill isleaftype #25496

Conversation

vtjnash commented Jan 10, 2018 • edited Loading

JeffBezanson Jan 10, 2018

Choose a reason for hiding this comment

JeffBezanson commented Jan 10, 2018

timholy Jan 10, 2018

Choose a reason for hiding this comment

nalimilan Jan 12, 2018

Choose a reason for hiding this comment

nalimilan Jan 12, 2018

Choose a reason for hiding this comment

vtjnash commented Jan 15, 2018

nanosoldier commented Jan 15, 2018

ararslan commented Jan 15, 2018

ararslan commented Jan 16, 2018

nanosoldier commented Jan 16, 2018

vtjnash commented Jan 16, 2018

ararslan commented Jan 16, 2018

nanosoldier commented Jan 17, 2018

vtjnash commented Jan 17, 2018

ararslan commented Jan 17, 2018

nanosoldier commented Jan 17, 2018

JeffBezanson commented Jan 19, 2018

kill `isleaftype` #25496

kill `isleaftype` #25496

vtjnash commented Jan 10, 2018 •

edited

Loading