Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vararg methods for mapreduce similar to map, fixes #27704. #31532

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Mar 29, 2019

This is not really an optimal implementation, but I wanted to try to get the functionality in for 1.2. Should be fine to make improvements later.

@tkf
Copy link
Member

tkf commented Mar 29, 2019

I think this can be optimized by lowering to Broadcasted-based mapreduce in #31020 in the future. That is to say, mapreduce(f, op, x, y, z) can call whatever mapreduce(identity, op, Broadcast.instantiate(Broadcast.broadcasted(f, x, y, z)))) would call internally.

@fredrikekre fredrikekre force-pushed the fe/multi-arg-mapreduce branch from b739916 to 052d276 Compare April 3, 2019 10:14
@fredrikekre fredrikekre force-pushed the fe/multi-arg-mapreduce branch from 052d276 to 48fd53d Compare April 3, 2019 10:20
@fredrikekre
Copy link
Member Author

bump

@StefanKarpinski
Copy link
Member

@mbauman: do you think you could review so that this can make it into 1.2?

@mbauman mbauman merged commit a24c38c into master Apr 3, 2019
@mbauman mbauman deleted the fe/multi-arg-mapreduce branch April 3, 2019 22:11
@mbauman
Copy link
Member

mbauman commented Apr 3, 2019

LGTM! Thanks @fredrikekre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants