-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Both LinearAlgebra and LinearAlgebra.BLAS export dot #626
Comments
Should we consider not exporting anything from |
I really like being able to do |
Let's just unexport the controversial one instead of making this more of a decision. |
LinearAlgebra exports the familiar `dot` function. The BLAS submodule has its own `dot` function, which it also exports, leading to problems if a user tries to access `dot` after `using` both LinearAlgebra and BLAS. Because this conflict currently exists, this change should be non-breaking, as it's difficult to resolve `dot` unqualified from BLAS before it's resolved from LinearAlgebra, so pretty much any consumer must already calling `BLAS.dot` as such. Fixes #31838.
Is it really necessary to make a change here? The I do think either keeping the exports or unexporting them all makes the most sense, and is a consistent decision. |
The way I see it is, if you're saying |
LinearAlgebra exports the familiar `dot` function. The BLAS submodule has its own `dot` function, which it also exports, leading to problems if a user tries to access `dot` after `using` both LinearAlgebra and BLAS. Because this conflict currently exists, this change should be non-breaking, as it's difficult to resolve `dot` unqualified from BLAS before it's resolved from LinearAlgebra, so pretty much any consumer must already calling `BLAS.dot` as such. Fixes #31838.
This is quite annoying:
It seems like BLAS should either extend
dot
from LinearAlgebra or not export its owndot
.The text was updated successfully, but these errors were encountered: