-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verbose option to @testset #33755
Conversation
Bump! :) |
I'd like to be able to specify the "depth of verbosity" with an option like |
Wouldn't it add unnecessary complications? I mean, with the current proposal, you can do that. Moreover, what would be the expected behavior if a parent has |
Bump # 2 :) |
Who would be the right person to review? @KristofferC ? |
Looking at the commits to |
Bump # 3 :) |
Bump # 4 |
Marking for triage so that this gets discussed. |
Bump # 5 :) (please, tell me if this should be closed or if this is not the right time to implement such change) |
Hi! Is there any chance to consider this modification for Julia 1.6? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase, but sgtm
Nice! I will rebase then. Thanks for the feedback @vtjnash ! |
The `verbose` option in `@testset` can be used to print the results of the childs even though all of them has passed. Closes #27088
@vtjnash Done! The test failure in macOS does not seem related to this PR. |
This addresses a feature I proposed in #27088 (sorry for the delay 😊). The idea is to provide a mean to
@testset
to print child results even though all of them passed. IMHO (as I mentioned in the issue), the default behavior starts to become a problem when you have a very big package and wants to be sure that all necessary tests are working.The way I coded is very simple: if
verbose = true
is passed to@testset
, then the statistics of the children will be printed regardless of the test results. Notice that this does not affect the children of the children.Thus, if we have:
we will get:
Notice that I chose to do not print the results of
Child 2
.P.S.: In this PR, I added the functionality and the test so that we can discuss. After discussing, I can add the documentation as well.