-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow ± and ∓ as unary operators #34200
Conversation
Will have to decide how to transition the parsing of e.g. |
I suppose merging this PR would make #33859 more breaking? |
Strictly speaking yes, but these operators are used much less often than + and -. |
I'm skeptical that all of these operators should be unary. |
Probably should not include ≏ "difference between", which doesn't make sense for 1 argument. |
Let's cut this down to just |
f8da55a
to
4b6d267
Compare
@JeffBezanson That seems like a good plan. Adding further operators can always be discussed later, so it makes sense to keep this more minimal. Could someone trigger PkgEval? |
@nanosoldier |
I think I did that right? 🤷♂ |
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
None of the failures seem related to this change (a lot of random tests with no seed being set—tsk, tsk) and a couple of segfaults, which are troubling but unlikely to be due to this. |
What is the current state on this? Is this acceptable minor breakage for a next release, or do we need to deprecate this syntax in whitespace sensitive contexts for a intermediary release? |
Seems fine for a minor release to me. |
Just needs a rebase and merge after CI passes. |
10baf3a
to
7c56556
Compare
This came up on slack, that it would be nice to have
±
as an allowed unary operator. This PR also adds∓
.further plus-like operators, which looked enough like. Probably should have tests, but I'm not quite sure what to test here exactly.+
and-
to make sense in my mind, but I can also remove the weirder ones, if so desired