-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#34234 normalize(a) for multidimensional arrays #34239
Conversation
Should this be backported? It seems simple and is partially a bug fix |
No, this is definitely a feature. The bugfix part could be backported. |
Case for OffsetArray where A[1] would fail but first(A) would not. Also some more test cases to compare with the vector case
The CI failures seem to be complaining about the Makefile and seem to be unrelated?
|
LGTM. Thanks for tackling this, @ssikdar1! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks very much @ssikdar1 for doing this!
* Add support normalize multi dim arrays * remove trailing whitespace from test * var name v => a for inner function * Update normalize tests Case for OffsetArray where A[1] would fail but first(A) would not. Also some more test cases to compare with the vector case * add NEWS item * make docstring example w/ array more julia-thonic * reduce redundant test cases * add test for normalize on Int64 array * add 0 1 and high dim test cases
PR to try and resolve issue JuliaLang/LinearAlgebra.jl#688
Testing:
added unit test to
stdlib/LinearAlgebra/test/generic.jl
ran
./julia stdlib/LinearAlgebra/test/generic.jl
with no errors.Testing in the shell: