Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make zero-periods compare equal #37486

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Make zero-periods compare equal #37486

merged 2 commits into from
Sep 16, 2020

Conversation

sostock
Copy link
Contributor

@sostock sostock commented Sep 9, 2020

Fixes #37459.

This makes e.g. Year(0) == Day(0) and adapts hash to the new behavior.

@quinnj quinnj merged commit bfa7261 into JuliaLang:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isequal is not transitive for Period/CompoundPeriod
2 participants
@sostock @quinnj