Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Manifest.toml format during code load #40765

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented May 10, 2021

Initial discussion in JuliaLang/Pkg.jl#2557

First Pkg PR JuliaLang/Pkg.jl#2561

  • Needs tests for loading from the new manifest format

base/loading.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth force-pushed the ib/new_manifest_format branch 2 times, most recently from 61b3e0e to a73d60f Compare May 30, 2021 06:04
@IanButterworth IanButterworth force-pushed the ib/new_manifest_format branch from a73d60f to fd4d1d1 Compare May 30, 2021 06:21
base/loading.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label May 30, 2021
Co-authored-by: Kristoffer Carlsson <[email protected]>
@IanButterworth IanButterworth changed the title WIP: Trying out a new manifest format - Support during code load Add support for new Manifest.toml format during code load May 30, 2021
@DilumAluthge DilumAluthge added the needs tests Unit tests are required for this change label May 31, 2021
@IanButterworth IanButterworth removed the needs tests Unit tests are required for this change label Jun 1, 2021
@IanButterworth IanButterworth marked this pull request as ready for review June 1, 2021 02:08
@DilumAluthge DilumAluthge requested a review from KristofferC June 1, 2021 02:37
@DilumAluthge DilumAluthge added this to the 1.7 milestone Jun 1, 2021
@DilumAluthge
Copy link
Member

I've added this to the 1.7 milestone BTW.

@KristofferC KristofferC merged commit fd905fa into JuliaLang:master Jun 2, 2021
@IanButterworth IanButterworth deleted the ib/new_manifest_format branch June 2, 2021 12:58
KristofferC pushed a commit that referenced this pull request Jun 4, 2021
* support new manifest format during code load

(cherry picked from commit fd905fa)
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
@StefanKarpinski
Copy link
Member

We had also discussed backporting support for the new manifest format to the 1.6 series since it will be the new LTS and we want moving back and forth to not become too annoying. Should this be backported to that branch as well?

@IanButterworth
Copy link
Member Author

Indeed. It's in #40702

and on the Pkg side
JuliaLang/Pkg.jl#2592
JuliaLang/Pkg.jl#2628 (WIP)

johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* support new manifest format during code load

(cherry picked from commit fd905fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants