Make @threads :dynamic default
#44136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Feb 12, 2022
tkf
approved these changes
Feb 12, 2022
|
Just for future search-ability, this PR is a conclusion of the feature seeded in #35646 and implemented in #43919. PR #43919 introduced The change in the code is minimal. So, I think it can be merged once CI is sufficiently happy. |
This was referenced Feb 12, 2022
DilumAluthge
removed
the
merge me
fredrikekre
reviewed
Feb 13, 2022
| Schedule options are: | ||
| - `:static` creates one task per thread and divides the iterations equally among | ||
| them, assigning each task specifically to each thread. | ||
| Specifying `:static` is an error if used from inside another `@threads` loop | ||
| or from a thread other than 1. | ||
| - `:dynamic` will schedule iterations dynamically to available worker threads, | ||
| - `:dynamic` (default) will schedule iterations dynamically to available worker threads, |
There was a problem hiding this comment.
Perhaps the default should be listed first
There was a problem hiding this comment.
makes sense #44163
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
Co-authored-by: Takafumi Arakaki <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Takafumi Arakaki <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Takafumi Arakaki <[email protected]>
jakobnissen
added a commit
to jakobnissen/julia
that referenced
this pull request
Aug 28, 2022
The docs on multithreading still warns that the default scheduler for @threads uses static scheduling. However, since JuliaLang#44136, dynamic scheduling has been the default. This commit removes the warning.
KristofferC
pushed a commit
that referenced
this pull request
Aug 29, 2022
KristofferC
pushed a commit
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #43919
Makes the new
:dynamicschedule forThreads.@threadsthe default.