-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF16 support #4930
Comments
UTF16 is not a ByteString. |
In what way? |
In that nearly every method we have defined for |
I.e. ASCIIString, UTF8String and ByteString. The only other potential candidate for ByteStringiness is Latin1 strings, but I'm not even sure that's a good idea. We've gotten remarkably far without ever needing to pass a Latin1 string to any C API. |
OK. It doesn't sound like there are any objections then? Just don't call it a bytestring? I'm quite all right with that. |
Yes, it's clearly something we need to do for Windows. |
Fine by me. I'll move the code over. |
We should probably leave the UTF16 as a do-nothing stub that prints a warning when loaded since people may well still be loading it for a while. |
^ package |
I was thinking about setting UTF16's REQUIRE to |
Sorry, huge reopen button on a small phone. So that 0.3 is a hard stop on when people can even have 0.3 installed through the package manager? |
Wow, that was fast. Thanks all! I may try to do some work on cleaning up the windows API stuff over thanksgiving (unless someone else wants to take it -- i would be more than happy to give it away). |
@StefanKarpinski Not sure i understand your comment. Would |
If it's just a stub, I'm not clear on why capping that allowable Julia version matters. |
To convert binary data to UTF-16, see also #6546. |
I would like to merge UTF16 support into base. My reason is that all the good windows API's require UTF16 support, so it would be nice to have native support for this
third ByteStringString type. (see also #1919)My intention was to move the code from the UTF16 package to Base:
https://github.com/nolta/UTF16.jl (@nolta)
Please let me know your concerns so I can attempt to address them.
The text was updated successfully, but these errors were encountered: