Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boolean indexing segfaults #5454

Closed
simonster opened this issue Jan 20, 2014 · 2 comments
Closed

boolean indexing segfaults #5454

simonster opened this issue Jan 20, 2014 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently regression Regression in behavior compared to a previous version
Milestone

Comments

@simonster
Copy link
Member

julia> cat(3, 1, 1, 1)[:, :, [true, true, false]]
fish: Job 1, “julia” terminated by signal SIGSEGV (Address boundary error)

With the original Cartesian commit (626b45b), this fails with:

julia> cat(3, 1, 1, 1)[:, :, [true, true, false]]
ERROR: BoundsError()
 in _F_ at multidimensional.jl:257
 in getindex! at cartesian.jl:74
 in _F_ at multidimensional.jl:39
 in getindex at cartesian.jl:74

Works fine with a1b21bf (last commit before Cartesian). cc @timholy

@JeffBezanson
Copy link
Member

Seems to be a combination of @inbounds and missing cases for boolean indexing.

@timholy
Copy link
Member

timholy commented Jan 20, 2014

Good catch. It turns out we really hadn't been testing logical indexing much, and indeed there was at least one other (long-standing) problem. Perhaps we need to add even more tests, but this should be a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

3 participants