use textwidth for string display truncation #55442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
textwidth
-based string-truncation functions from #55351 (with some additional refactoring) for truncating strings in the 3-argumentshow
, replacing the codepoint-based method implemented by @StefanKarpinski in #40736.It makes a big difference when displaying strings that have width-2 or width-0 characters. For example, in the previous implementation, you got very unequal-length displays for different character widths:
Now, you get:
(They look more equal in my terminal. In my browser,
🍕
is slightly more than 2 columns wide 😕.)