Fix 'Rebase [ittapi] Check out branch only if ITTAPI is cloned' #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disabled the build of `MLIRExecutionEngineShared` because this causes linkage issues in windows for currently unknown reasons. Related issue: llvm#106859. (cherry picked from commit 74e1062)
Fix by not setting working directory as ittapi source dir might not exist. Also, quote paths in case of whitespace
|
Go ahead. I can create a pr upstreaming but not sure if it will be accepted given it would break stuff. |
|
Actually 8e56593 is a separate upstream pr fixing a bug. Though, if you want to squash it too go ahead. |
|
Ok, I'll leave 8e56593 out, no problem |
giordano
force-pushed
the
julia-release/19.x
branch
from
3a19532
to
dae0320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested yggy and Julia build with this.