Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface.jl #7

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Update interface.jl #7

merged 3 commits into from
Nov 8, 2021

Conversation

phipsgabler
Copy link
Contributor

AFAIK, shouldn't throw objects that are not Exceptions.

AFAIK, shouldn't `throw` objects that are not `Exception`s.
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #7 (f82c3b9) into master (7c4718a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           36        37    +1     
=========================================
+ Hits            36        37    +1     
Impacted Files Coverage Δ
src/interface.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4718a...f82c3b9. Read the comment docs.

@oschulz
Copy link
Collaborator

oschulz commented Nov 8, 2021

Oh, indeed, that's a bug. We forgot to wrap the string in an ArgumentError().

src/interface.jl Outdated Show resolved Hide resolved
@oschulz oschulz merged commit d23645a into JuliaMath:master Nov 8, 2021
@oschulz
Copy link
Collaborator

oschulz commented Nov 8, 2021

Thanks @phipsgabler !

@phipsgabler phipsgabler deleted the patch-1 branch November 8, 2021 15:04
@oschulz
Copy link
Collaborator

oschulz commented Nov 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants