Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential future problem: rounding mode changed in core Julia #13

Closed
tomasaschan opened this issue Dec 26, 2014 · 1 comment
Closed

Comments

@tomasaschan
Copy link
Contributor

Julia's rounding behavior will change in 0.4 (see JuliaLang/julia#8750 and JuliaLang/julia#9344), and I suspect it might throw off our indexing, since we do things like x_i = round(T, x) to figure out which polynomial we should evaluate. I think it might not be a problem, since ties will coincide with cell boundaries (and thus yield the same value regardless of which cell is used for evaluation), but I'm putting this up here to remember that it might blow up and that I should add tests for it some day.

@tomasaschan
Copy link
Contributor Author

This seems to not have caused problems for us. Closing for housekeeping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant