Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

estimate_covar doubles the use of the weights #85

Closed
stakaz opened this issue Oct 4, 2018 · 1 comment
Closed

estimate_covar doubles the use of the weights #85

stakaz opened this issue Oct 4, 2018 · 1 comment

Comments

@stakaz
Copy link
Contributor

stakaz commented Oct 4, 2018

Since the weights are already included in the function which we want to minimize, the correct covarinace should be: `inv(J' * J). I have tested it with the generalized least square covariance estimators and the results agree. I am wokring on a pull request for this and some more issues...
@pkofod
Copy link
Member

pkofod commented Oct 8, 2018

This is fixed, correct?

@pkofod pkofod closed this as completed Oct 8, 2018
@pkofod pkofod mentioned this issue Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stakaz @pkofod