Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is Element mutable? #21

Closed
jw3126 opened this issue Sep 16, 2018 · 3 comments
Closed

Why is Element mutable? #21

jw3126 opened this issue Sep 16, 2018 · 3 comments

Comments

@jw3126
Copy link
Contributor

jw3126 commented Sep 16, 2018

I just realized, that Element is a mutable struct. This seems strange, is it intended?
@rahulkp220
Copy link
Member

No, it's not intended, neither the Element should be mutable. Should be changed to just struct. @crstnbr @stevengj agreed?

@carstenbauer
Copy link
Member

Good catch, certainly not intended. Dropping the mutable should work without any further changes. @jw3126 wanna make a simple PR?

@jw3126
Copy link
Contributor Author

jw3126 commented Sep 16, 2018

sure!

@jw3126 jw3126 mentioned this issue Sep 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carstenbauer @jw3126 @rahulkp220