Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type piracy for LinearAlgebra.I #649

Closed
baggepinnen opened this issue Jul 5, 2022 · 2 comments
Closed

Type piracy for LinearAlgebra.I #649

baggepinnen opened this issue Jul 5, 2022 · 2 comments

Comments

@baggepinnen
Copy link

Importing this package completely breaks LinearAlgebra.I and all code that makes use of it:

julia> using LinearAlgebra

julia> I(2)
2×2 Diagonal{Bool, Vector{Bool}}:
 1  
   1

julia> import ReachabilityAnalysis as RA

julia> I(2)
MathematicalSystems.IdentityMultiple{Float64} of value 1.0 and order 2

Notice that the code above does not import any names from ReachabilityAnalysis, still the I was overridden. Importing this packages thus breaks all code in every package that uses LinearAlgebra.I.

Tested with ReachabilityAnalysis v0.18.7

@baggepinnen
Copy link
Author

I just noticed that the offending method lives in MathematicalSystems.jl

@mforets
Copy link
Member

mforets commented Aug 4, 2022

Thanks for opening the issue. I think we can close this, since it was fixed upstream.

@mforets mforets closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants