Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored multi agent proposal #926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mytolo
Copy link
Contributor

@Mytolo Mytolo commented Jul 11, 2023

Instead of returning a generator for RLBase.plan! use NamedTuples s.t. the environment is able to gather the actions for the players correctly. It might be that the iteration of the environment is not in order (for example, this might occur when it is wrapped from another language into julia).

Moreover, this PR includes proper push operations for the Basic Agent policy for simultaneous dynamicStyle trait envs. They were missing. Hence, the trajectory was not updated acordingly.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #926 (ec34889) into main (1f7f347) will decrease coverage by 13.65%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #926       +/-   ##
==========================================
- Coverage   13.64%   0.00%   -13.65%     
==========================================
  Files         217     208        -9     
  Lines        7571    7415      -156     
==========================================
- Hits         1033       0     -1033     
- Misses       6538    7415      +877     
Impacted Files Coverage Δ
...inforcementLearningCore/src/policies/agent/base.jl 0.00% <0.00%> (ø)
...mentLearningCore/src/policies/agent/multi_agent.jl 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

@Mytolo
Copy link
Contributor Author

Mytolo commented Jul 19, 2023

NOTE: CI fail depends on rework of run loop as RLBase.plan! is executed after termination of environment as stated in #913, PR #921

@HenriDeh
Copy link
Member

HenriDeh commented Sep 4, 2023

Doesn't the new loop work for you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants