Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake script #23

Closed
stevengj opened this issue Mar 6, 2015 · 4 comments · Fixed by #28
Closed

cmake script #23

stevengj opened this issue Mar 6, 2015 · 4 comments · Fixed by #28

Comments

@stevengj
Copy link
Member

stevengj commented Mar 6, 2015

It would be nice to include a cmake script (a CMakeLists.txt file) to make life easier for Windows users. Since utf8proc is so simple, we can easily maintain both this and a Makefile.

@tkelman tkelman self-assigned this Mar 6, 2015
@tkelman
Copy link
Contributor

tkelman commented Mar 6, 2015

I'll do this. Should also turn on AppVeyor while we're at it. Are we targetting a 1.2.0 release some point soon, where we would want to get this in?

@stevengj
Copy link
Member Author

stevengj commented Mar 6, 2015

I'd like to do a 1.2.0 release soon after #2 is resolved (since that will break ABI compatibility, though the API will still be backwards compatible).

@stevengj
Copy link
Member Author

stevengj commented Mar 8, 2015

(PS. Don't bother trying to reproduce the data regeneration scripts in cmake. Since we run those so rarely, it's reasonable to run them only on Unices. Just make a minimal CMakeLists that builds libutf8proc from utf8proc.c)

@tkelman
Copy link
Contributor

tkelman commented Mar 8, 2015

Yeah, I don't suspect it to be more than 20 lines, really.

We will want to disallow in-tree builds from cmake though, to avoid overwriting the existing makefiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants