Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Could a Logging Feature Be Added to HTTP.jl? #922

Open
TheCedarPrince opened this issue Sep 8, 2022 · 3 comments
Open

[FEATURE] Could a Logging Feature Be Added to HTTP.jl? #922

TheCedarPrince opened this issue Sep 8, 2022 · 3 comments

Comments

@TheCedarPrince
Copy link

Version Details:

Please specify the following versions when submitting a bug report:

  • Julia 1.6
  • HTTP.jl 1
  • MbedTLS.jl N/A

Issue Details

This is more of a cross issue from DataDeps.jl based on a discussion there in this issue.@oxinabox said once upon a time that logging of downloads could be possible and that she had it working once upon a time for DataDeps.jl.

@VarshC and I were working on a package today and encountered a situation where her internet was quite spotty - the download from DataDeps didn't stop but it did seem to hang. Having a progress bar option/ability would help give us as users feedback to know if either a download is still happening, paused, or significantly slowed due to poor internet stability.

Is this possible to add into HTTP.jl or outside the scope of this package?

Thanks!

~ tcp 🌳

@quinnj
Copy link
Member

quinnj commented Sep 8, 2022

So to clarify, the request here is for logging download progress when using HTTP.download?

@TheCedarPrince
Copy link
Author

TheCedarPrince commented Sep 8, 2022

Hi @quinnj - I am sure @oxinabox could comment better but based on the download structure here: https://github.com/oxinabox/DataDeps.jl/blob/master/src/resolution_automatic.jl I believe the answer is yes.

P.S. Jacob you are so insanely fast on this it is amazing. 😄

@oxinabox
Copy link
Member

oxinabox commented Sep 17, 2022

This used to work as long as you had a ProgressLogging.jl based logger being used.
Which establishes the principle that having a named log argument called progress should be displayed as a progress bar or similar.
I believe TerminalLoggers.jl is one such logging package.

It definitely used to work in Juno.
And using OhMyLog.jl.

Even without such a logger install HTTP download should be printing a number for progress and a speed and an ETA.
It just won't be a bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants