Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Make WebBrowser and ArchiWebHandler support cancellation #3067

Closed
7 tasks done
JustArchi opened this issue Nov 11, 2023 · 0 comments
Closed
7 tasks done

[BREAKING] Make WebBrowser and ArchiWebHandler support cancellation #3067

JustArchi opened this issue Nov 11, 2023 · 0 comments
Labels
💣 Breaking changes Issues marked with this label indicate possible breaking changes that might need major version bump. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

Checklist

Enhancement purpose

Underlying HttpClient supports cancellation, allow callers to use it if they need to.

Solution

CancellationToken cancellationToken = default + passing it around in all our code.

Why currently available solutions are not sufficient?

There is no reason why callers shouldn't be able to use this mechanism if they want to.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

Breaking change for all inheritors, don't ship before .NET 8 when we break more things.
@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. 💣 Breaking changes Issues marked with this label indicate possible breaking changes that might need major version bump. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Nov 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💣 Breaking changes Issues marked with this label indicate possible breaking changes that might need major version bump. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustArchi