Some characters are now saved as escape sequences on BotName.json file #3301
Labels
✨ Enhancement
Issues marked with this label indicate further enhancements to the program, such as new features.
🟢 Low priority
Issues marked with this label are actively being worked on if nothing serious is on the list.
🐍 Not a bug
Issues marked with this label indicate that given behaviour is intended to happen - not a bug.
🙏 Wishlist
Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Checklist
ASF version
Latest pre-release
ASF variant
linux-x64
Bug description
Since long ago (probably when you moved from newtonsoft to stj) some characters on BotName.json property are modified by ASF upon running to their escape sequence counterparts.
As an example:
"CustomGamePlayedWhileIdle": "Exchanging Cards, Emotes & BGs..."
becomes
"CustomGamePlayedWhileIdle": "Exchanging Cards, Emotes \u0026 BGs..."
Expected behavior
Strings at BotName.json file for properties such as
CustomGamePlayedWhileIdle
orCustomGamePlayedWhileFarming
should remain untouched with the original value the people enters.Actual behavior
Strings at BotName.json file for properties such as
CustomGamePlayedWhileIdle
orCustomGamePlayedWhileFarming
are escaped.Steps to reproduce
"CustomGamePlayedWhileIdle": "Exchanging Cards, Emotes & BGs..."
Reopen your configuration file to check that now value for
CustomGamePlayedWhileIdle
contains escape sequences.Possible reason/solution
Defaults behaviour of Std seems to escape characters, this is not the same for old serializer newtonsoft
Can you help us with this bug report?
Yes, I can help with the testing if required.
Full log.txt recorded during reproducing the problem
Global ASF.json config file
N/A
BotName.json config of all affected bot instances
N/A
Additional info
I'm not aware if changing back from escape sequences to regular characters comes with any security concern.
Please double check at your side and evaluate if it is possible to get back the old behaviour.
The text was updated successfully, but these errors were encountered: