Fix typo in data constructor highlighting regex

* Fixes some problems with slow/frozen highlighting (see #161)
JustusAdam · Jun 22, 2020 · 05bfeff · 05bfeff
1 parent 75aa09b
commit 05bfeff
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/syntaxes/haskell.YAML-tmLanguage b/syntaxes/haskell.YAML-tmLanguage
@@ -1033,15 +1033,15 @@ repository:
               # Type inside balanced brackets
               | ('? # Optional promotion tick
                   (?<brac>
-                    \(          # Opening bracket
+                    \[          # Opening bracket
                     (?:
                       [^\[\]]*  # Match non-brackets
                     | \g<brac>  # or recurse into further depth
                     )*
                     \]          # Closing bracket
                   )
                 )
-              )        
+              )
               # Then either
               \s*
                 # - a symbolic infix constructor, or

diff --git a/test/tickets/T0161.hs b/test/tickets/T0161.hs
@@ -0,0 +1,25 @@
+-- SYNTAX TEST "source.haskell" "Data constructor highlighting"
+
+    data Foo a = (:>) a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a a  
+--  ^^^^ keyword.other.data.haskell 
+--             ^ keyword.operator.eq.haskell
+--                ^^ constant.other.operator.haskell
+--           ^        ^ ^ ^                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ^ ^ ^ variable.other.generic-type.haskell
+
+    data Foo a = (:>) `C` ( S, O ) deriving ( Show, Ord )
+--  ^^^^ keyword.other.data.haskell 
+--           ^ variable.other.generic-type.haskell
+--             ^ keyword.operator.eq.haskell
+--                ^^ storage.type.operator.haskell
+--                ^^ - constant.other.operator.haskell
+--                     ^ constant.other.haskell
+--                                 ^^^^^^^^ keyword.other.deriving.haskell
+--       ^^^                ^  ^              ^^^^  ^^^ storage.type.haskell
+
+    data Foo a = (:>) Bar a deriving ( Show, Ord )
+--  ^^^^ keyword.other.data.haskell 
+--             ^ keyword.operator.eq.haskell
+--                ^^ constant.other.operator.haskell
+--           ^            ^ variable.other.generic-type.haskell
+--                          ^^^^^^^^ keyword.other.deriving.haskell
+--       ^^^          ^^^              ^^^^  ^^^ storage.type.haskell