Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regresion: comments on records are not highlighted properly #121

Closed
emlautarom1 opened this issue Apr 26, 2020 · 6 comments
Closed

Regresion: comments on records are not highlighted properly #121

emlautarom1 opened this issue Apr 26, 2020 · 6 comments

Comments

@emlautarom1
Copy link

Only the last comment is highlighted properly while all the other ones are displayed as plain text

comments

@sheaf
Copy link
Collaborator

sheaf commented Apr 26, 2020

This seems to be due to the comma. If you put the comma at the start of the next line instead, it highlights OK.

@emlautarom1
Copy link
Author

emlautarom1 commented Apr 26, 2020

Indeed, this fixes the issue. Sadly I just "can't" put the comma in the next line since I'm using ormolu as my code formatter and this is the way it handles records.

Edit: I think that brittany handles records with a comma in the next line, so they might ignore that this issue exists at all

@JustusAdam
Copy link
Owner

Thank you for reporting this. 👍 Will be fixed in the next release.

@sheaf
Copy link
Collaborator

sheaf commented Apr 27, 2020

This issue doesn't seem to be limited to records:
comment_highlighting

@sheaf
Copy link
Collaborator

sheaf commented Apr 30, 2020

Bisecting shows that 562e08d was responsible for this issue.

@sheaf
Copy link
Collaborator

sheaf commented May 3, 2020

Fixed in 8188d55.

sheaf added a commit to sheaf/language-haskell that referenced this issue May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants