Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualified type operator exports #226

Closed
wants to merge 1 commit into from
Closed

Qualified type operator exports #226

wants to merge 1 commit into from

Conversation

mixphix
Copy link
Contributor

@mixphix mixphix commented May 18, 2023

Fixes #191.

@sheaf
Copy link
Collaborator

sheaf commented May 19, 2023

Thank you so much, that's a great fix.

Could you:

  • add a test case for type (Qualified.T),
  • squash the commits?

Then we should be good to go!

@mixphix mixphix force-pushed the issue-191 branch 3 times, most recently from e6efbc0 to f942c0a Compare May 19, 2023 12:12
@mixphix
qualified type operator exports
a311c80 
includes instead of matching in the end

fix test comments

update changelog

remove added garbage

add test case for exporting type Qualified.T

fix magichash
@mixphix
Copy link
Contributor Author

mixphix commented May 19, 2023

An issue with MagicHash caught me by surprise in the (now fixed, thanks!) tests. I threw reserved_symbol into the includes and now everything works again! :)

@sheaf
Copy link
Collaborator

sheaf commented May 19, 2023

Rebase needed, otherwise this is good to go. Thanks a lot!

Does your patch now also fix the following issue (that I found out after you mentioned MagicHash)?

module M
  ( T#(f#,C#,(+#)) )
  where

The (+#) currently throws everything off.

@mixphix
Copy link
Contributor Author

mixphix commented May 19, 2023 •
edited
Loading

It does not. Actually, there's a number of issues remaining here, one of which is that I didn't notice the where clause has now been discoloured due to the end match. I'll have to work on this some more.

@mixphix mixphix closed this May 19, 2023
@mixphix
Copy link
Contributor Author

mixphix commented May 19, 2023

The (+#) currently throws everything off.

This is partly a problem with prefix_op, which does not allow # to appear at the end of such things, and partly with the hash symbol match itself, which does not register as such when immediately followed by (.

@mixphix
Copy link
Contributor Author

mixphix commented May 19, 2023

FWIW I’ve fixed the issue with the where keyword. If the other hash stuff is already caught in a test that’s expected to fail (for now), I’ll reopen this with just the qualification patch?

@sheaf
Copy link
Collaborator

sheaf commented May 19, 2023

Yes that's good with me, I'll make a separate "expect fail" test for the magic hash issue. Thanks.

@mixphix
Copy link
Contributor Author

mixphix commented May 19, 2023

Womp womp. Can't re-open because I force-pushed. Sorry, I'll make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qualified infix type operator in export list causes issues
2 participants
@mixphix @sheaf