Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literate Haskell #7

Closed
Miguel-Fontes opened this issue Dec 14, 2016 · 4 comments
Closed

Literate Haskell #7

Miguel-Fontes opened this issue Dec 14, 2016 · 4 comments

Comments

@Miguel-Fontes
Copy link
Contributor

Hi JustusAdam!

Do you have any useful background about what's happening with Literate Haskell syntax?

I've just cloned your repo and looking forward to take a shot at this issue. I'm still getting my head into vscode extension development and it will be my first contact with textmate syntax definitions so, no warrants included.

Thank you!

@JustusAdam
Copy link
Owner

Not really unfortunately.

Feel free to ask me some questions about vscode extensions.
The texmate sytax stuff I only know the basics myself. It was enough to write the definition for the .cabal file, but in case of literal Haskell it uses some fancy include syntax that I don't really comprehend myself. I tried copying the definitions from the haskell.texmate bundle but they don't work in vscode for some reason.
Feel free to take a stab at it though.

@Miguel-Fontes
Copy link
Contributor Author

Miguel-Fontes commented Dec 14, 2016

Right.

So, after totally destroying your project 3 times (this is why we are developers! right?) i got to the point below. I must say, kind sir, my writings are somewhat colorful right now.

I've tested with some personal lhs files and everything looks alright until now. Example below.

I've created a PR as i could't find any other problems. Tell me if there's anything else about this issue! Thanks, friend!

The cause: the grammar wasn't wired at package.json. After the adjustments at 'contributes.language' and 'contributes.grammar' Literate Haskell is available.

is-it-right-question-mark

@JustusAdam
Copy link
Owner

So I guess we can close this then. The change is live on the marketplace with version 1.2.3

@Miguel-Fontes
Copy link
Contributor Author

Closed. New version up and running.

You should take out that warning about lhs support being disabled at README.md. I totally forgot about that.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants