Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mustache-1.0.2 test suite failure on NixOS #19

Open
peti opened this issue Jul 2, 2016 · 1 comment
Open

mustache-1.0.2 test suite failure on NixOS #19

peti opened this issue Jul 2, 2016 · 1 comment

Comments

@peti
Copy link

peti commented Jul 2, 2016

It seems the test suite tries to execute curl?

running tests
Running 2 test suites...
Test suite unit-tests: RUNNING...
Test suite unit-tests: PASS
Test suite logged to: dist/test/mustache-1.0.2-unit-tests.log
Test suite language-specifications: RUNNING...
language-specifications: curl: callProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Test suite language-specifications: FAIL
Test suite logged to: dist/test/mustache-1.0.2-language-specifications.log
1 of 2 test suites (1 of 2 test cases) passed.

That won't wok because (a) curl hasn't been declared as a build-tool and thus isn't available in the build environment and (b) builds don't have network access anyway. How would I remedy this issue? Is there a way to run those tests without depending on the network?

@JustusAdam
Copy link
Owner

Theoretically the tests don't rely on the network.
The reason they use the network is to download specifications for the test suite for the mustache specs from this repo and this fork specifically this file: https://codeload.github.com/mustache/spec/tar.gz/v1.1.3 and this one https://codeload.github.com/andrewthad/spec/legacy.tar.gz/add_list_context_check.

If the files were present by some other means the network would not be required at all (although I'd have to change the tests slightly).

Furthermore theoretically the unit tests are sufficient, since they cover basically all the same cases, however these integration tests are run against the official spec which is a nice insurance to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants