Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tensorflowjs #1298

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Pin tensorflowjs #1298

merged 1 commit into from
Sep 15, 2023

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Sep 15, 2023

A new version of tensorflowjs has been released and requires tensorflow

= 2.13. We are currently using 2.12 and this is causing a test failure.

Full context in bug.

http://b/300552705

A new version of tensorflowjs has been released and requires tensorflow
>= 2.13. We are currently using 2.12 and this is causing a test failure.

Full context in bug.

http://b/300552705
@rosbo rosbo requested a review from djherbis September 15, 2023 03:28
@rosbo
Copy link
Contributor Author

rosbo commented Sep 15, 2023

tensorflowjs test is now passing:

test_version (test_tensorflowjs.TestTensorflowjs) ... tensorflowjs_converter version:  CompletedProcess(args=['tensorflowjs_converter', '--version'], returncode=0, stdout=b'\ntensorflowjs 4.10.0\n\nDependency versions:\n  keras 2.12.0\n  tensorflow 2.12.0\n', stderr=b'2023-09-15 05:08:52.715863: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT\n')
ok

There is another unrelated test failure related to pandas. Will investigate on Monday.

@rosbo rosbo merged commit 13d16bd into main Sep 15, 2023
3 checks passed
@rosbo rosbo deleted the pin-tensorflowjs branch September 15, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants