Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue On Ready: Bookmarks Don't Always Connect to their Icon #1

Open
KaizNike opened this issue Feb 11, 2024 · 0 comments
Open

Issue On Ready: Bookmarks Don't Always Connect to their Icon #1

KaizNike opened this issue Feb 11, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KaizNike
Copy link
Owner

Brief: When the project starts, the ready function in app.gd loads the LWBData.tres if available and copies the bookmarks to the script. It then summons helper HTTPRequests that connect to the existing IconHTTPRequest script to make bookmark icons in the second bar. They don't always have the same site connected to them as the image, generating confusion.

Possible Fixes:

  • Create New Function replacing IconHTTPRequest that has similar functionality but only for the ready function.
  • Pass additional data to IconHTTPRequest, but this wasn't obvious.
  • Make a helper make_bookmark(site, icon) function.
@KaizNike KaizNike added bug Something isn't working good first issue Good for newcomers labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant