Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #8

Open
7 of 16 tasks
st9007a opened this issue Jul 6, 2022 · 0 comments
Open
7 of 16 tasks

Refactor #8

st9007a opened this issue Jul 6, 2022 · 0 comments

Comments

@st9007a
Copy link
Collaborator

st9007a commented Jul 6, 2022

High Priority

  • Add unit testing into KIN
  • Add integration tests to CUT, CycleGAN, F-LSeSim
    • Test CUT
    • Test CyclyGAN
    • Test F-LSeSim

Low Priority

  • Add eps
  • Add typing and docstring.
  • Update default python version to 3.9
  • Record anchors in a way other than image filenames

Heavily Refactor

  • Ensure dependencies of padding and kernel size.
    • KIN padded_std_table, padded_mean_table => cached_property
    • Padding in the forward function could be removed. It depends on kernel size.
    • Add reset function
      • Design function signature
  • Define state, use enum:
1. trainging => IN
2. infer => IN and Collect
   - create a table
   - create a kernel
3. infer => KIN and Use cache
   - Use the table
   - Use the kernel
  • Merge x_anchor and y_anchor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant