Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indication that some of the connectors mandatory properties are not yet configured #126

Closed
tplevko opened this issue Sep 18, 2023 · 0 comments · Fixed by #659
Closed

Indication that some of the connectors mandatory properties are not yet configured #126

tplevko opened this issue Sep 18, 2023 · 0 comments · Fixed by #659
Assignees
Labels
canvas/visualization Canvas-related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX
Milestone

Comments

@tplevko
Copy link
Contributor

tplevko commented Sep 18, 2023

Please describe the feature that you want to propose

It would be useful to show in the flow diagram that some of the connectors are not yet configured. The connectors have "mandatory" fields and the nodes could be displaying configuration status decorators, as in attached image.
Screenshot from 2023-09-18 13-21-23

const NODES: NodeModel[] = [
  {
    id: 'node-0',
    type: 'node',
    label: 'Node 0',
    width: NODE_DIAMETER,
    height: NODE_DIAMETER,
    shape: NodeShape.ellipse,
    status: NodeStatus.danger,
    data: {
      badge: 'B',
      isAlternate: false
    }
  },
  {
    id: 'node-1',
    type: 'node',
    label: 'Node 1',
    width: NODE_DIAMETER,
    height: NODE_DIAMETER,
    shape: NodeShape.hexagon,
    status: NodeStatus.warning,
    data: {
      badge: 'B',
      isAlternate: false
    }
  },
  {
    id: 'node-2',
    type: 'node',
    label: 'Node 2',
    width: NODE_DIAMETER,
    height: NODE_DIAMETER,
    shape: NodeShape.octagon,
    status: NodeStatus.success,
    data: {
      badge: 'A',
      isAlternate: true
    }
  },

above is from the PF example code. The interesting part is the status: NodeStatus.xxx which controls what icon is displayed.

@tplevko tplevko added enhancement New feature or request canvas/visualization Canvas-related issues labels Sep 18, 2023
@lhein lhein moved this to Backlog in Kanban Board Sep 21, 2023
@lhein lhein added this to the 0.1.0 - Smart Connectors' MVP milestone Sep 21, 2023
@lhein lhein moved this from Backlog to Todo in Kanban Board Sep 21, 2023
@lhein lhein modified the milestones: Smart Connectors' MVP, Feature Parity Nov 2, 2023
@lhein lhein added the ui/ux This issue is about improving the UI / UX label Dec 5, 2023
@lhein lhein modified the milestones: 2.1.0, 2.0.0 Dec 9, 2023
@igarashitm igarashitm modified the milestones: 2.0.0 TP, 2.0.0 Jan 10, 2024
@igarashitm igarashitm self-assigned this Jan 13, 2024
@igarashitm igarashitm moved this from Todo to In Progress in Kanban Board Jan 13, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 17, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 17, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 17, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
@igarashitm igarashitm moved this from In Progress to In Review in Kanban Board Jan 18, 2024
igarashitm added a commit to igarashitm/kaoto that referenced this issue Jan 18, 2024
lordrip pushed a commit that referenced this issue Jan 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/visualization Canvas-related issues enhancement New feature or request ui/ux This issue is about improving the UI / UX
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants