Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed more Camel Catalog versions by default #1392

Closed
apupier opened this issue Sep 5, 2024 · 5 comments · Fixed by #1650
Closed

Embed more Camel Catalog versions by default #1392

apupier opened this issue Sep 5, 2024 · 5 comments · Fixed by #1650
Assignees
Labels
catalog Catalog-related issues enhancement New feature or request
Milestone

Comments

@apupier
Copy link
Member

apupier commented Sep 5, 2024

Please describe the feature that you want to propose

Currently there is only latest community version.

I think we should have:

  • latest community version at time of release
  • latest LTS community version at time of release
  • Red Hat supported versions
@lordrip lordrip moved this from New to Todo in Kanban Board Sep 10, 2024
@lordrip lordrip added the catalog Catalog-related issues label Sep 10, 2024
@lhein lhein added this to the 2.3.0 milestone Sep 13, 2024
@lhein lhein changed the title Embed more Catalog by default Embed more Camel Catalog versions by default Sep 13, 2024
@lordrip
Copy link
Member

lordrip commented Oct 2, 2024

Putting it on hold as we need the --json output from the Camel CLI

@lordrip lordrip moved this from Todo to Blocked in Kanban Board Oct 2, 2024
@apupier
Copy link
Member Author

apupier commented Oct 2, 2024

I think it would be better to have the list manually maintained. If using an automated way, if there is a release of Camel right before the Kaoto release it will pick it without further testing.
It also ensures reproducible build and to eb able to have a trace in the changelog.

@apupier apupier added the enhancement New feature or request label Oct 3, 2024
@igarashitm igarashitm modified the milestones: 2.3.0, 2.4.0 Oct 29, 2024
@lhein lhein modified the milestones: 2.4.0, 2.3.0 Nov 14, 2024
@apupier
Copy link
Member Author

apupier commented Nov 20, 2024

would be convenient to have #1597 fixed to implement this one. But there is a workaround by providing a settings;xml with Red Hat Maven repository.
this can (I think) be done in the GitHub Actions directly https://github.com/actions/setup-java?tab=readme-ov-file#maven-options. otherwise other options/
* pass the parameters on command-line in github workflow
* commit a settings.xml to use during build

EDIT: #1597 has been fixed so no need to customize anything

@apupier apupier moved this from Blocked to Todo in Kanban Board Nov 21, 2024
@apupier
Copy link
Member Author

apupier commented Nov 21, 2024

I do not find find where/how the catalog is generated. Seems currently like the version picked depends on the version defined as dependency in the pom.xml currently, this is not parameters provided somewhere else

edit: I guess it is here

"build:default:catalog": "yarn run build:mvn; java -jar ./target/catalog-generator-0.0.1-SNAPSHOT.jar -o ./dist/camel-catalog -n \"Default Kaoto catalog\"",
"build:ts": "node --loader ts-node/esm ./scripts/json-schema-to-typescript.mts",

@apupier apupier moved this from Todo to In Progress in Kanban Board Nov 21, 2024
@apupier apupier self-assigned this Nov 21, 2024
@lordrip
Copy link
Member

lordrip commented Nov 21, 2024

Yes, is exactly there, we pick whatever is defined in the pom.xml

lordrip added a commit to lordrip/kaoto that referenced this issue Nov 21, 2024
Currently, only the latest Camel version is available in the catalog.

This commit includes RHBAC versions in the Kaoto catalog.

fix: KaotoIO#1392
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Nov 21, 2024
@lordrip lordrip self-assigned this Nov 21, 2024
lordrip added a commit that referenced this issue Nov 21, 2024
Currently, only the latest Camel version is available in the catalog.

This commit includes RHBAC versions in the Kaoto catalog.

fix: #1392
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catalog Catalog-related issues enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants