Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tokenizer EIP #1550

Closed
lordrip opened this issue Oct 9, 2024 · 0 comments · Fixed by #1551
Closed

Support for Tokenizer EIP #1550

lordrip opened this issue Oct 9, 2024 · 0 comments · Fixed by #1551
Assignees
Labels
canvas/config-form Configuration form related issues
Milestone

Comments

@lordrip
Copy link
Member

lordrip commented Oct 9, 2024

Please describe the feature that you want to propose

With the upcoming refactor of the Tokenizer EIP, we need to support oneOf schemas.

Relates to: #948

@lordrip lordrip added the canvas/config-form Configuration form related issues label Oct 9, 2024
@lordrip lordrip added this to the 2.3.0 milestone Oct 9, 2024
@lordrip lordrip self-assigned this Oct 9, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 9, 2024
Currently, we have partial support for the `oneOf` schemas.

This commit cleans up the generated schemas, by removing the `not`
definition from `oneOf` and also removing the empty properties like:

'''
{
  property: { }
}
'''

fix: KaotoIO#1550
fix: KaotoIO#948
@lordrip lordrip moved this from New to In Review in Kanban Board Oct 9, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 9, 2024
Currently, we have partial support for the `oneOf` schemas.

This commit cleans up the generated schemas, by removing the `not`
definition from `oneOf` and also removing the empty properties like:

'''
{
  property: { }
}
'''

fix: KaotoIO#1550
fix: KaotoIO#948
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 10, 2024
Currently, we have partial support for the `oneOf` schemas.

This commit cleans up the generated schemas, by removing the `not`
definition from `oneOf` and also removing the empty properties like:

'''
{
  property: { }
}
'''

fix: KaotoIO#1550
fix: KaotoIO#948
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/config-form Configuration form related issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant